Skip to content

Treat architecture design as a convention - #812

Merged
Sun Haoran (haoranpb) merged 7 commits into
mainfrom
copilot/explore-module-communication-ideas
Aug 25, 2026
Merged

Treat architecture design as a convention#812
Sun Haoran (haoranpb) merged 7 commits into
mainfrom
copilot/explore-module-communication-ideas

Conversation

Copilot AI commented Aug 21, 2026

Copy link
Copy Markdown
Contributor

Summary

  • Replace the rigid import-graph test with concise guidance that preserves one-way dependency flow and the special EvaluationCategory registry.
  • Introduce AgentRunner as the typed injection boundary and use it across all evaluation pipelines.
  • Keep lightweight Ruff safeguards for absolute imports and common correctness issues.

Rationale

Architecture remains a reviewable convention without maintaining an exhaustive module graph. CLI commands select concrete agents, pipelines receive them through AgentRunner, and bcbench.types remains the central category registry.

Validation

  • uv run pytest: 746 passed, 1 skipped
  • uv run pre-commit run --all-files: passed

Comment thread src/bcbench/evaluate/testgeneration.py
Comment thread src/bcbench/evaluate/base.py
Copilot AI and others added 5 commits August 25, 2026 08:45
Co-authored-by: haoranpb <27280733+haoranpb@users.noreply.github.com>
Co-authored-by: haoranpb <27280733+haoranpb@users.noreply.github.com>
Co-authored-by: haoranpb <27280733+haoranpb@users.noreply.github.com>
Co-authored-by: haoranpb <27280733+haoranpb@users.noreply.github.com>
Co-authored-by: haoranpb <27280733+haoranpb@users.noreply.github.com>
@haoranpb
Sun Haoran (haoranpb) force-pushed the copilot/explore-module-communication-ideas branch from e9df1f8 to 5e63cfa Compare August 25, 2026 06:46
Comment thread src/bcbench/commands/evaluate.py Dismissed
Comment thread tests/test_evaluate_pipeline.py Dismissed
@haoranpb
Sun Haoran (haoranpb) marked this pull request as ready for review August 25, 2026 07:05
@haoranpb
Sun Haoran (haoranpb) enabled auto-merge (squash) August 25, 2026 07:10
@haoranpb
Sun Haoran (haoranpb) merged commit d5df69b into main Aug 25, 2026
14 of 16 checks passed
@haoranpb
Sun Haoran (haoranpb) deleted the copilot/explore-module-communication-ideas branch August 25, 2026 07:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants